Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python Windows unicode issues (maybe) #8830

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 27, 2025

Fixes nightly ci. Maybe. This works just fine on my machine and any unicode printing issue should have been fixed long ago, see https://peps.python.org/pep-0528/

@Wumpf Wumpf added exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

Web viewer failed to build.

Result Commit Link Manifest
https://rerun.io/viewer/pr/8830 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link

github-actions bot commented Jan 27, 2025

Latest documentation preview deployed successfully.

Result Commit Link
188c2c7 https://landing-l7zd5au5y-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@Wumpf
Copy link
Member Author

Wumpf commented Jan 27, 2025

.encode("utf-8") ruins it for all ci jobs

@Wumpf
Copy link
Member Author

Wumpf commented Jan 27, 2025

@Wumpf Wumpf marked this pull request as ready for review January 27, 2025 18:51
@Wumpf
Copy link
Member Author

Wumpf commented Jan 27, 2025

merging this in without review - I really want nightly to be green again and there's not much to be reviewed.
Although, maybe @abey79 has an opinion on this?

@Wumpf Wumpf merged commit 7eb3735 into main Jan 27, 2025
22 of 28 checks passed
@Wumpf Wumpf deleted the andreas/windows-nightly-fix branch January 27, 2025 18:53
@abey79
Copy link
Member

abey79 commented Jan 28, 2025

merging this in without review - I really want nightly to be green again and there's not much to be reviewed. Although, maybe @abey79 has an opinion on this?

Not really. I'm not familiar with that stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants