-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to ReScript v11 #738
Migrate to ReScript v11 #738
Conversation
This PR allows us to move forward with document generation from docstrings compiler because |
@@ -57,11 +57,11 @@ module Link = { | |||
~href: string, | |||
~_as: string=?, | |||
~prefetch: bool=?, | |||
~replace: option<bool>=?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this how it works in ReScript 11 now due to uncurried-by-default? Or was this wrong ever since?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I noticed we actually already vendored the encoding / decoding lib. I still feel like the extra manual Js.Json decoding is a little unweildy and annoying to maintain... any ways to keep the original logic somehow?
I removed Json interface files because they are reporting signature errors. |
@ryyppy I merged #739 in this PR. But I got some errors which I think are related to rescript-lang/rescript#6413 When I create a
|
^ @cknitt any idea? |
Need: let array = (encode, l) => jsonArray(Array.map(x => encode(x), l)) The change is |
Thanks Cristiano!! Added .resi files for Json |
Getting an warning 45 SidebarLayout.Toc module.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Generate.bs.mjs
instead.mjs
, since we are using ESMTODO: