Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve binding of BottomTabs, MaterialBottomTabs #75

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −2
Open

Improve binding of BottomTabs, MaterialBottomTabs #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9b3e79
tabBarLabel polymorphic
namenu Feb 3, 2025
246d25e
BottomTabs - add tabBarLabel.position arg
namenu Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/BottomTabs.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,17 @@ module TabBarBadge = {
external string: string => t = "%identity"
}

@unboxed
type rec tabBarLabel = String(string) | Function(tabBarLabelArgs => React.element)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need recursive type for this

and tabBarLabelArgs = {
focused: bool,
color: string,
position: tabBarLabelPosition,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not adding the children arg ?


type rec options = {
title?: string,
tabBarLabel?: string,
tabBarLabel?: tabBarLabel,
tabBarShowLabel?: bool,
tabBarLabelPosition?: tabBarLabelPosition,
tabBarLabelStyle?: Style.t,
Expand Down
6 changes: 5 additions & 1 deletion src/MaterialBottomTabs.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,15 @@ module TabBarBadge = {
external string: string => t = "%identity"
}

@unboxed
type rec tabBarLabel = String(string) | Function(tabBarLabelArgs => React.element)
and tabBarLabelArgs = {focused: bool, color: string}

type options = {
title?: string,
tabBarIcon?: tabBarIconOptions => React.element,
tabBarColor?: Color.t,
tabBarLabel?: string,
tabBarLabel?: tabBarLabel,
tabBarBadge?: TabBarBadge.t,
tabBarAccessibilityLabel?: string,
tabBarTestID?: string,
Expand Down