Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better OpenAlex support #1316

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Better OpenAlex support #1316

wants to merge 4 commits into from

Conversation

ewan-escience
Copy link
Collaborator

Better OpenAlex support

Changes proposed in this pull request

  • Allow for finding mentions by OpenAlex ID
  • Also search in the OpenAlex database when searching for mentions by title
  • Expand the mentions scraper to also include mentions with an OpenAlex ID (and no DOI)
  • Updated the respective docs

How to test

  • docker compose down --volumes && docker compose build --parallel && docker compose up --scale data-generation=0
  • Add mentions with a DOI
  • Add mentions with an OpenAlex ID but no DOI (see e.g.https://research-software-directory.org/api/v1/mention?external_id=not.is.null&doi=is.null&select=title,doi,external_id&limit=100)
  • Add mentions by searching for a title, OpenAlex results should also show up
  • Add these mentions in various places (reference papers for software, other mentions for software, project impact, project output)
  • Afterwards, run the mentions scraper, no errors should be reported:
  • docker compose exec scrapers java -cp /usr/myjava/scrapers.jar nl.esciencecenter.rsd.scraper.doi.MainMentions

Closes #1312

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@ewan-escience ewan-escience self-assigned this Oct 10, 2024
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Failed Quality Gate failed for 'scrapers'

Failed conditions
14.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

sonarcloud bot commented Oct 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better OpenAlex support
1 participant