Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select accessibility and logo size #1385

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Jan 30, 2025

Improve accessibility

Closes #1375
Closes #1373

Changes proposed in this pull request:

  • Add aria label to select number of items on the overview pages
  • Made logos of the same size. Note! The logo height is set to 3rem. This is best we can do due to various logo ratios.  
  • Remove on hover color on source code logos

How to test:

  • make start to build and generate test data
  • visit software overview page and run Lighthouse audit, accessibility section (check accessiblity) - see image below
  • edit software page, add github as repository and package manager

Accessibility

image

Expected score

image

Example logos

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility - page drop-down options Github logos different size
1 participant