Mrc 4804 Single Select #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mrc-4808 #6 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 6 7 +1
Lines 88 110 +22
Branches 25 28 +3
==========================================
+ Hits 88 110 +22 ☔ View full report in Codecov by Sentry. |
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We finally have a demo! You can now run (after
npm i)npm run devand see the single single select in action! The big margins and long page is for a future PR but left it in so you can see the problem. if you scroll the menu goes off the bottom of the page! Anyways, that is for another PR :)After all that setup, the actual single select component is pretty simple. It emits an { id, label } object for the option that was clicked on which is consistent with our filter selections state!