Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated variable interpolation syntax in PHP 8.2 #78

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

JoyceBabu
Copy link
Contributor

Using ${var} in strings is deprecated. This is the only instance where the deprecated syntax is used.

@pprkut
Copy link
Collaborator

pprkut commented Oct 2, 2023

@danhunsaker I can't merge this myself because of the branch protection rules, and don't have permission to check/update those 🙁

@danhunsaker
Copy link
Member

@JoyceBabu Sorry for the delay on this. We can't quite merge until this gets a rebase, unfortunately, and it looks like we don't have permissions to update your PR. Can you rebase this?

@pprkut That should be fixed, now. Had the rules too restrictive, as you noted above. I'll try to figure out boosting your permissions, though I don't have much control over that since we're in Resque's namespace.

@pprkut
Copy link
Collaborator

pprkut commented Apr 28, 2024

@danhunsaker Thank you! Much appreciated 🙂

@JoyceBabu JoyceBabu force-pushed the fix-php82-string-interpolation branch from c4c6985 to 1e1ea09 Compare April 28, 2024 18:10
@JoyceBabu
Copy link
Contributor Author

I have rebased the commit.

@pprkut pprkut merged commit 929dca1 into resque:develop Apr 28, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants