Add sqrt to SigmaZ values since it is calculated with GetSigmaZ2() #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the XZ_SigmaZ and YZ_SigmaZ observables were being find by simply using GetSigmaZ2(). This GetSigmaZ2() is the squared value of SigmaZ, for example we can see that the GetSigmaX() does the same calculations as GetSigmaZ2() but the applies the squared root. By adding sqrt we find XZ_SigmaZ instead of XZ_SigmaZ2, which is what we were calculating before.
For a given file we see how we get the squared root of 2 of the observables of interest, so instead of sigmaZ2 we get SigmaZ as the observable name indicates:
Fig 1: Before the change we had this values.
Fig 2: After the change.