Fix envoy dynamic forward proxy config #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
LGTM. +1 for merging.
Have you tried these changes out @jackkleeman?
| @@ -183,7 +183,8 @@ spec: | |||
| value: 127.0.0.1:10001 | |||
| # ... | |||
| - name: envoy | |||
| image: envoyproxy/envoy:distroless-v1.26.1 | |||
| # use a bleeding edge image until v1.17 is released | |||
There was a problem hiding this comment.
Suggested change
| # use a bleeding edge image until v1.17 is released | |
| # use a bleeding edge image until v1.27 is released |
There was a problem hiding this comment.
Maybe also add the link to the envoy issue which we are waiting on.
|
yes, its running in the kube cluster already |
|
Shall we merge this @jackkleeman? |
The current config is not correctly load balancing over different endpoints. We rely on the feature merged in envoyproxy/envoy#26420; this should be in envoy 1.27, in the meantime we can use dev envoy.
jackkleeman
force-pushed
the
fix-envoy-dfp
branch
from
0346c7c
to
9dd4695
Compare
✅ Deploy Preview for docsrestatedev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current config is not correctly load balancing over different endpoints. We rely on the feature merged in envoyproxy/envoy#26420; this should be in envoy 1.27, in the meantime we can use dev envoy.