Add oauth proxy edge function #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsrestatedev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jackkleeman
changed the title
Otherwise build fails
tillrohrmann
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Nicely done @jackkleeman. Really cool that we now have authorization for our documentation! +1 for merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using Netlify Identity auth, which seems quite expensive and not that trivial to set up, we can just use an edge function to send people through a github redirect flow, get their github token, check they have access to this repo, and then issue a jwt with 1 week expiry
To test it out:
Go to https://deploy-preview-88--docsrestatedev.netlify.app/
Enter the password
wev0puh2ufe@UMJ6ncd- we need this until this is merged, as we don't have the function set up on prod yetThen you should go through a github redirect flow and come back to whatever page you first landed on
Fixes #85