Skip to content

Commit

Permalink
Just dont log on completion chan close
Browse files Browse the repository at this point in the history
  • Loading branch information
jackkleeman committed Jul 8, 2024
1 parent b7c8fd4 commit 80898c3
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions internal/state/completion.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,11 @@ package state

import (
"context"
"errors"
"fmt"
"io"
"sync"

"github.com/restatedev/sdk-go/generated/proto/protocol"
"github.com/restatedev/sdk-go/internal/wire"
"golang.org/x/net/http2"
"google.golang.org/protobuf/proto"
)

Expand Down Expand Up @@ -151,15 +148,6 @@ func (m *Machine) handleCompletionsAcks() {
for {
msg, err := m.protocol.Read()
if err != nil {
if errors.Is(err, io.EOF) {
return
}
var t *http2.StreamError
if errors.As(err, &t) && t.Code == http2.ErrCodeNo {
// normal close
return
}
m.log.Error().Err(err).Msg("issue reading completions & acks")
return
}
switch msg.Type() {
Expand Down

0 comments on commit 80898c3

Please sign in to comment.