Skip to content

Commit

Permalink
Remove some of the TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
igalshilman committed Sep 5, 2024
1 parent 822be77 commit aa14076
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ impl PyVM {
&mut self_.vm,
Cow::Owned(error),
description.map(Cow::Owned).unwrap_or(Cow::Borrowed("")),
None, // TODO: use the next retry hint
None,
);
}

Expand Down Expand Up @@ -456,18 +456,14 @@ impl PyVM {
RunEnterResult::Executed(NonEmptyValue::Failure(f)) => {
PyFailure::from(f).into_py(py).into_bound(py).into_any()
}
RunEnterResult::NotExecuted(retry_info) => {
// TODO: implement this
PyNone::get_bound(py).to_owned().into_any()
}
RunEnterResult::NotExecuted(_retry_info) => PyNone::get_bound(py).to_owned().into_any(),
})
}

fn sys_run_exit_success(
mut self_: PyRefMut<'_, Self>,
buffer: &Bound<'_, PyBytes>,
) -> Result<PyAsyncResultHandle, PyVMError> {
// TODO: Figure out what is the RunExit value
CoreVM::sys_run_exit(
&mut self_.vm,
RunExitResult::Success(buffer.as_bytes().to_vec().into()),
Expand Down

0 comments on commit aa14076

Please sign in to comment.