Ensure replayed logs aren't emitted (#403)

Also create a console.log()
restatedev · Jul 12, 2024 · 2e9baa7 · 2e9baa7
1 parent abdd44d
commit 2e9baa7
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 10 deletions.
diff --git a/packages/restate-sdk/src/logger.ts b/packages/restate-sdk/src/logger.ts
@@ -80,6 +80,9 @@ export const defaultLogger: Logger = (
   message?: any,
   ...optionalParams: any[]
 ) => {
+  if (params.replaying) {
+    return;
+  }
   if (logLevel(params.level) < logLevel(DEFAULT_LOGGER_LOG_LEVEL)) {
     return;
   }
@@ -171,6 +174,13 @@ export function createRestateConsole(
   context?: LoggerContext,
   isReplaying: () => boolean = () => false
 ): Console {
+  const info = loggerForLevel(
+    logger,
+    source,
+    RestateLogLevel.INFO,
+    isReplaying,
+    context
+  );
   return Object.create(console, {
     trace: loggerForLevel(
       logger,
@@ -186,13 +196,8 @@ export function createRestateConsole(
       isReplaying,
       context
     ),
-    info: loggerForLevel(
-      logger,
-      source,
-      RestateLogLevel.INFO,
-      isReplaying,
-      context
-    ),
+    info,
+    log: info,
     warn: loggerForLevel(
       logger,
       source,

diff --git a/packages/restate-sdk/src/state_machine.ts b/packages/restate-sdk/src/state_machine.ts
@@ -95,11 +95,15 @@ export class StateMachine implements RestateStreamConsumer {
     this.localStateStore = invocation.localStateStore;
     this.console = createStateMachineConsole(logger, loggerContext);
 
+    this.journal = new Journal(this.invocation);
     this.restateContext = new ContextImpl(
       this.invocation.id,
       // The console exposed by RestateContext filters logs in replay, while the internal one is based on the ENV variables.
-      createRestateConsole(logger, LogSource.USER, loggerContext, () =>
-        this.journal.isReplaying()
+      createRestateConsole(
+        logger,
+        LogSource.USER,
+        loggerContext,
+        this.journal.isReplaying.bind(this.journal)
       ),
       handlerKind,
       invocation.userKey,
@@ -108,7 +112,6 @@ export class StateMachine implements RestateStreamConsumer {
       connection.headers(),
       this
     );
-    this.journal = new Journal(this.invocation);
     this.promiseCombinatorTracker = new PromiseCombinatorTracker(
       this.readCombinatorOrderEntry.bind(this),
       this.writeCombinatorOrderEntry.bind(this)