Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow printing stacktrace when invocations finish with an error #226

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

AhmedSoliman
Copy link
Collaborator

@AhmedSoliman AhmedSoliman commented Jan 11, 2024

Allow printing stacktrace when invocations finish with an error

@AhmedSoliman
Copy link
Collaborator Author

Worth noting that this will print the javascript stacktrace, in order to see references to the TypeScript source, the user needs to add NODE_OPTIONS=--enable-source-maps to env to enable this. I don't know if there is an automatic/better way to do this that doesn't require users to do anything extra.

Copy link

github-actions bot commented Jan 11, 2024

Test Results

102 files  ±0  102 suites  ±0   11m 36s ⏱️ + 1m 26s
 93 tests ±0   93 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e52988f. ± Comparison against base commit 68f58bf.

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman changed the title [WIP] Allow printing stacktrace when invocations finish with an error Allow printing stacktrace when invocations finish with an error Jan 11, 2024
@AhmedSoliman AhmedSoliman marked this pull request as ready for review January 11, 2024 14:45
@AhmedSoliman AhmedSoliman merged commit 0d4d58a into main Jan 11, 2024
5 checks passed
@slinkydeveloper slinkydeveloper deleted the pr226 branch January 11, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants