Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guard for RestateContext.sideEffect await #227

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Add guard for RestateContext.sideEffect await #227

merged 1 commit into from
Jan 17, 2024

Conversation

slinkydeveloper
Copy link
Contributor

Fix #197

@slinkydeveloper slinkydeveloper changed the title Add guard for RestateContext.sideEffect await [WIP] Add guard for RestateContext.sideEffect await Jan 15, 2024
@slinkydeveloper
Copy link
Contributor Author

slinkydeveloper commented Jan 15, 2024 •
edited
Loading

TODO: Fix ctx.sleep call on retries (it should not check for the executingSideEffect guard) Done

@slinkydeveloper slinkydeveloper changed the title [WIP] Add guard for RestateContext.sideEffect await Add guard for RestateContext.sideEffect await Jan 15, 2024
igalshilman
igalshilman approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@igalshilman igalshilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, When the tests and e2e are passing I’m okay to merge.
You may want to run a verification test for a bit longer locally just for safety.

@slinkydeveloper slinkydeveloper merged commit 66e82fe into restatedev:main Jan 17, 2024
2 checks passed
@slinkydeveloper slinkydeveloper deleted the issues/197_guard_approach branch January 17, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalshilman igalshilman igalshilman approved these changes

@StephanEwen StephanEwen Awaiting requested review from StephanEwen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Side effect entry can be overtaken if not awaited
2 participants
@slinkydeveloper @igalshilman