Awakeable identifiers following the new ID scheme #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results102 files ±0 102 suites ±0 15m 49s ⏱️ + 5m 37s For more details on these failures, see this check. Results for commit 90fa26b. ± Comparison against base commit 766a642. ♻️ This comment has been updated with latest results. |
AhmedSoliman
force-pushed
the
pr238
branch
2 times, most recently
from
c955bb2
to
22756bc
Compare
Bonus: `s/assumpsions/assumptions/`
Test Plan:
Using sample code to generate an awakeable and resolved it with
```
curl localhost:8080/dev.restate.Awakeables/Resolve -H 'content-type: application/json' -d '{"id": "prom_1NMyOAvDK2CcBjUH4Rmb7eGBp0DNNDnmsAAAAAQ", "json_result": ""}'
```
```
[restate] [2024-01-25T18:54:01.682Z] DEBUG: [CheckoutProcess/checkout] [inv_13q6r7rhzaG85fs0bfyqW8cubIUYJFjvBT] : Resuming (replaying) function.
Awakeable is: prom_1NMyOAvDK2CcBjUH4Rmb7eGBp0DNNDnmsAAAAAQ
Awakeable COMPLETED prom_1NMyOAvDK2CcBjUH4Rmb7eGBp0DNNDnmsAAAAAQ
```
slinkydeveloper
approved these changes
Jan 26, 2024
There's no version to bump yet, still need to solve #235 first |
|
For posterity, tests pass locally but we have a full mesh of dependency such that there is no way e2e tests will pass without merging the sdk first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awakeable identifiers following the new ID scheme
Bonus:
s/assumpsions/assumptions/Server side in restatedev/restate#1120
Test Plan:
Using sample code to generate an awakeable and resolved it with