Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format checking and linting during builds #241

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Fix format checking and linting during builds #241

merged 2 commits into from
Jan 31, 2024

Conversation

StephanEwen
Copy link
Contributor

Makes sure that the builds (and the format / lint commands) properly fail (return exit code != 0) when finding format errors and lint warnings.

igalshilman
igalshilman approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@igalshilman igalshilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@slinkydeveloper slinkydeveloper self-assigned this Jan 31, 2024
@slinkydeveloper
Copy link
Contributor

I'll take over this PR.

@github-actions GitHub Actions
Copy link

Test Results

102 files  ±0  102 suites  ±0   10m 14s ⏱️ +16s
 93 tests ±0   93 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 195044c. ± Comparison against base commit 9844cad.

@slinkydeveloper slinkydeveloper merged commit e4f6e95 into main Jan 31, 2024
3 checks passed
@slinkydeveloper slinkydeveloper deleted the fix_verify branch January 31, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalshilman igalshilman igalshilman approved these changes

Assignees

@slinkydeveloper slinkydeveloper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StephanEwen @slinkydeveloper @igalshilman