Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add src/ directory to the restate-sdk package #267

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

igalshilman
Copy link
Contributor

@igalshilman igalshilman commented Feb 28, 2024

This PR adds the src/ directory to the list of files to be included in the restate-sdk package.

Running npm pack creates a tarball with the ./src directory included.

Note that, with this change, the bundle size is: 3,1M

@StephanEwen
Copy link
Contributor

looks good in general. how much of that size is generated protobuf code?

@igalshilman
Copy link
Contributor Author

@StephanEwen The generated protobuf:

572K	./src/generated
1,3M	./dist/generated

This will get smaller, once we move to the new API.

I'll proceed in merging this for now, and if a bundle size will become an issue, we'll find a better way.

@igalshilman igalshilman merged commit 1a5e235 into restatedev:main Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants