Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scheduler)!: rework constructor to use configuration options #148

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

reugn
Copy link
Owner

@reugn reugn commented Jan 31, 2025

Breaking changes intorduced to quartz.StdScheduler:

  • The NewStdSchedulerWithOptions constructor has been removed and configuration options added to NewStdScheduler.
  • The NewStdScheduler constructor now returns a scheduler instance and an error that should be handled.

Breaking changes intorduced to logger.Logger:

  • The global instance of logger.Logger has been removed, and a WithLogger(logger logger.Logger) option has been added to the quartz.StdScheduler configuration options.
  • The logger.Logger interface methods have been updated.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.67816% with 11 lines in your changes missing coverage. Please review.

Project coverage is 94.53%. Comparing base (6226674) to head (229fb58).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
quartz/scheduler.go 91.85% 11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   95.01%   94.53%   -0.48%     
==========================================
  Files          19       19              
  Lines         962     1152     +190     
==========================================
+ Hits          914     1089     +175     
- Misses         32       46      +14     
- Partials       16       17       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reugn reugn merged commit 4bb9433 into master Feb 1, 2025
5 checks passed
@reugn reugn deleted the scheduler-configuration-options branch February 1, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants