-
Notifications
You must be signed in to change notification settings - Fork 7
#419 Upload Profile Picture Button Styles #432
Conversation
@jwietelmann I just pushed up style updates for the profile picture onboarding flow (styled based on mocks in Abstract here: https://app.goabstract.com/projects/b52ae8a0-8a13-11e8-a66c-3fc17367628a/branches/master/commits/8a0f0edef2897e956ec3ddedb338f65d19310e23/files/AE300282-67A5-42F5-A47D-180F88B20490/layers/82CF174C-FF88-41E4-ABFF-0316D2D30346?mode=design). We still need to set two things up:
If we can't set the two above items up, I can fix the design accordingly so it looks good. I'm also only going off of how the mocks look in Abstract, because the Dropbox video they sent us doesn't show the animations for how the profile picture is added. I say we make a new ticket for the Animations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions and a few console.logs
Can self merge after fixing
src/Accounts/account.js
Outdated
changes.profile_pic_url = await uploadImageToCloudinary(newProfilePic) | ||
} | ||
|
||
console.log('changes', changes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove console.log
<View style={accountStyles.rowContainer}> | ||
<View style={accountStyles.row}> | ||
<View style={[ticketWalletStyles.avatarContainer, accountStyles.avatarContainer]}> | ||
<Image | ||
style={ticketWalletStyles.avatar} | ||
source={avatarPlaceholder} | ||
source={this.profilePicSourceToDisplay} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this show a placeholder if profilePicSourceToDisplay returns null?
@@ -2,6 +2,8 @@ import {Constants} from 'expo' | |||
|
|||
const RELEASE_CHANNEL = Constants.manifest.releaseChannel || 'dev' | |||
const WEB_STAGING = 'https://beta.bigneon.com' | |||
const CLOUDINARY_CLOUD_STAGING = 'bigneon-dev' | |||
const CLOUDINARY_UPLOAD_PRESET_STAGING = 'dthcf8uc' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a different one for production? And does this get carried over into the production config if not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It gets carried over into the production config if not. I don't know if we have a different one for production or not. I just grabbed what I found when i inspected the request on beta web.
src/state/authStateProvider.js
Outdated
@@ -3,6 +3,13 @@ import {AsyncStorage} from 'react-native' | |||
import {server, refreshWithToken, apiErrorAlert} from '../constants/Server' | |||
|
|||
/* eslint-disable camelcase,space-before-function-paren */ | |||
|
|||
function shouldDoAdditionalSignUpStep(currentUser) { | |||
console.log('currentUser', currentUser) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another console
…bs/bn-mobile-react into 419-upload-profile-pic
Connect #418
Connect #419
Requires #408
Note:
The Sign Up screen still needs to be broken out into separate parts (see video in ticket). I went ahead and added the button to the current screen but once we break these out in #408 we will need to move over the second two inputs (Email and Password), and keep the Add Profile button with the First and Last name inputs.