Skip to content
This repository has been archived by the owner on Jun 11, 2019. It is now read-only.

#419 Upload Profile Picture Button Styles #432

Merged
merged 15 commits into from
Jan 11, 2019
Merged

Conversation

brittanygay
Copy link

@brittanygay brittanygay commented Jan 3, 2019

Connect #418
Connect #419
Requires #408

  • Stubbed out and styled the Add Profile Picture button on the SignUp screen
  • Fixed a few alignment bugs that I found on the Login/Signup screen

Note:
The Sign Up screen still needs to be broken out into separate parts (see video in ticket). I went ahead and added the button to the current screen but once we break these out in #408 we will need to move over the second two inputs (Email and Password), and keep the Add Profile button with the First and Last name inputs.

screen shot 2019-01-03 at 4 45 55 pm

@brittanygay brittanygay self-assigned this Jan 3, 2019
@brittanygay brittanygay changed the title #419 Upload Profile Picture Button Styles [DO NOT MERGE] #419 Upload Profile Picture Button Styles Jan 3, 2019
@brittanygay
Copy link
Author

@jwietelmann I just pushed up style updates for the profile picture onboarding flow (styled based on mocks in Abstract here: https://app.goabstract.com/projects/b52ae8a0-8a13-11e8-a66c-3fc17367628a/branches/master/commits/8a0f0edef2897e956ec3ddedb338f65d19310e23/files/AE300282-67A5-42F5-A47D-180F88B20490/layers/82CF174C-FF88-41E4-ABFF-0316D2D30346?mode=design).

We still need to set two things up:

  1. Connect the name with the username that's filled out at the top in the Pill container once the image is uploaded
  2. We also need to add if they are VIP or not (pretty sure we don't have this set up, though?)

If we can't set the two above items up, I can fix the design accordingly so it looks good.

I'm also only going off of how the mocks look in Abstract, because the Dropbox video they sent us doesn't show the animations for how the profile picture is added. I say we make a new ticket for the Animations.

Here's a gif of how it's looking now:
demo-large-4

@jwietelmann jwietelmann changed the title [DO NOT MERGE] #419 Upload Profile Picture Button Styles #419 Upload Profile Picture Button Styles Jan 10, 2019
Copy link

@daybreaker daybreaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions and a few console.logs

Can self merge after fixing

changes.profile_pic_url = await uploadImageToCloudinary(newProfilePic)
}

console.log('changes', changes)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console.log

<View style={accountStyles.rowContainer}>
<View style={accountStyles.row}>
<View style={[ticketWalletStyles.avatarContainer, accountStyles.avatarContainer]}>
<Image
style={ticketWalletStyles.avatar}
source={avatarPlaceholder}
source={this.profilePicSourceToDisplay}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this show a placeholder if profilePicSourceToDisplay returns null?

@@ -2,6 +2,8 @@ import {Constants} from 'expo'

const RELEASE_CHANNEL = Constants.manifest.releaseChannel || 'dev'
const WEB_STAGING = 'https://beta.bigneon.com'
const CLOUDINARY_CLOUD_STAGING = 'bigneon-dev'
const CLOUDINARY_UPLOAD_PRESET_STAGING = 'dthcf8uc'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a different one for production? And does this get carried over into the production config if not?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets carried over into the production config if not. I don't know if we have a different one for production or not. I just grabbed what I found when i inspected the request on beta web.

@@ -3,6 +3,13 @@ import {AsyncStorage} from 'react-native'
import {server, refreshWithToken, apiErrorAlert} from '../constants/Server'

/* eslint-disable camelcase,space-before-function-paren */

function shouldDoAdditionalSignUpStep(currentUser) {
console.log('currentUser', currentUser)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another console

@daybreaker daybreaker merged commit fd7fc74 into develop Jan 11, 2019
@daybreaker daybreaker deleted the 419-upload-profile-pic branch January 11, 2019 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants