Tests for GithubCommands module #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoffsMH
commented
May 19, 2019
| def create_reusable_stories( | ||
| %{project_name: project_name} = results, | ||
| %{project_name: project_name, github_repo: _} = results, |
There was a problem hiding this comment.
requiring this field in the results map allows us to skip the step if there is no github_repo to post reusable stories to
HoffsMH
commented
May 19, 2019
| end | ||
| end | ||
|
|
||
| def create_reusable_stories(results, _, _, _, _), do: results |
There was a problem hiding this comment.
The default case when no github_repo from a previous step exist is now to just return the results map
HoffsMH
commented
May 19, 2019
| @@ -138,7 +151,7 @@ defmodule Slax.Commands.GithubCommands do | |||
| end) | |||
| |> Enum.split_with(fn | |||
| {:ok, _, _} -> true | |||
| {:error, _} -> false | |||
| {:error, _, _} -> false | |||
There was a problem hiding this comment.
the previous Enum.map was generating either 2-element :ok tuples or 3-element :error tuples but split_with was matching on a 2-element :error tuple here. This resulted in split_with raising an error any time there was an error creating an issue.
bryanjos
approved these changes
May 24, 2019
|
@HoffsMH looks like there is a conflict |
added 8 commits
May 24, 2019 10:40
including error stats when various requests fail or formatting is incorrect
…ons or change module names when refactoring
…e_stories and the result set doesnt include a github repo, which means that even if we were to parse out the story issues correctly there would be nothing to send them to. a github repo should be a hard requirement for this step
HoffsMH
force-pushed
the
github-commands-tests
branch
from
6a0eced to
e9863f1
Compare
|
@bryanjos Rebased! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #48, according to my coveralls this puts coverage at 57%
Also fixes a couple bugs in the module which I will leave comments next to
I took the liberty of trying to converge on a common spelling of
reusableif there is a preferred alternate spelling let me know and I can rename.If this is too hefty I can split out into separate PRs as well!