Clean up output dir validation #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against da5546c |
| @@ -1226,7 +1235,7 @@ def main(): | |||
| logger.setLevel(logging.INFO) | |||
|
|
|||
| # validate the project, and if --validateonly flag is set, return True if validation passes | |||
| GcpBatch.validate_project(os.path.abspath(args.project_filename), args.missingonly) | |||
| GcpBatch.validate_project(os.path.abspath(args.project_filename)) | |||
There was a problem hiding this comment.
should we also add args.missingonly here and avoid checking for that in the check_output_dir?
There was a problem hiding this comment.
I'm not sure if this is what you meant, but I moved the missingonly check out of check_output_dir and put it below.
buildstockbatch/gcp/gcp.py
Outdated
| user_choice = ( | ||
| input( | ||
| f"Output files are already present in bucket {self.gcs_bucket}! For example, {blob.name} exists. " | ||
| f"Do you want to delete all the files in {prefix_for_deletion}? (yes/no): " |
There was a problem hiding this comment.
Thinking maybe we add also the warning that if you delete these files, you won't be able to recover them or something like that?
There was a problem hiding this comment.
Added "permanently" to the prompt. Do you think that's enough?
mfathollahzadeh
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the "check for existing files in the output dir" step out of the validation function.
There are enough cases where we do validation but don't want to do this check that I think it makes sense to keep it separate. (
--missingonly,--clean,--postprocessonly,--showjobs)