Refactored bug reporting to log to one function. #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezalas
approved these changes
Feb 29, 2024
|
Most definitely. Didn't want to mess with the messages, though, as I thought that would clutter the meaning behind the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is prep work for including a standardized logging framework (such as
spdlog) to the codebase. It takes the three different bug reporting functions and consolidated them under theRS.Bugfunction.The one in
db.cwas confusing to reason about and was error-prone, as a previous PR showed. The one inmud.c(RS.Bug) includes the gist of what the one indb.cwas trying to convey.