Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spdlog and support class #254

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

sean-gilliam
Copy link
Collaborator

This PR adds the spdlog logging framework to the codebase. It's the next step in integrating a more modern framework for logging rather than our homegrown solution.

This PR just adds the framework and a support class. No other changes have been made, as this is rather top-heavy as it is.

The support class needs to be incorporated with CMud to control the life cycle and such, but that is another future PR :)

@sean-gilliam sean-gilliam requested review from rezalas and Psypher9 March 5, 2024 00:26
@github-actions github-actions bot added the core label Mar 5, 2024
Copy link
Collaborator

@Psypher9 Psypher9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@rezalas rezalas merged commit dfac902 into rezalas:main Mar 5, 2024
3 checks passed
@sean-gilliam sean-gilliam deleted the add-spdlog branch March 5, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants