-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging infrastructure update #256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's what the log file shows on a clean run
|
We can update the logging pattern later. This was just the bare-bones first attempt to get something together. |
Psypher9
requested changes
Mar 9, 2024
These log screen caps look beautiful |
Gruvbox Material Dark theme |
This is awesome progress man!!! I'm looking forward to this so I can rebase and continue work on the stored procedures. |
Psypher9
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all references to the old
RS.Bug
/RS.Log
to the newCLogger
methods.Things to note:
Removed the
fmt
library sincespdlog
already bundled it. All references switched to the one underspdlog
.Tied
errno
messages previously displayed byperror
tostd::strerror(errno)
so those messages flow through our logging infra.bugout
/bugexit
still exists for the time being so we can come up with a logging plan for them.Sorry for this extremely hefty PR. I broke it out over several commits to help digest it more easily. Let me know if you have questions/concerns.