add mutually exclusive plot types

rfbgo · Nov 15, 2024 · 30ca944 · 30ca944
1 parent 8a5cf5a
commit 30ca944
Show file tree

Hide file tree

Showing 2 changed files with 89 additions and 130 deletions.
diff --git a/lib/ramble/ramble/cmd/results.py b/lib/ramble/ramble/cmd/results.py
@@ -39,57 +39,56 @@ def setup_parser(subparser):
         action="store",
         help="the workspace to report on",
     )
-    report_parser.add_argument(
+
+    # The plot type should be exclusive, and only one plot type is supported per invocation
+    plot_type_group = report_parser.add_mutually_exclusive_group(required=True)
+    plot_type_group.add_argument(
         "--strong-scaling",
         dest="strong_scaling",
         nargs="+",
-        action="append",
         help="generate a scaling report, requires two args: [y-axis metric] [x-axis metric]"
         "[optional: group by]",
         required=False,
     )
-    report_parser.add_argument(
+    plot_type_group.add_argument(
         "--weak-scaling",
         dest="weak_scaling",
         nargs="+",
-        action="append",
         help="generate a scaling report, requires two args: [y-axis metric] [x-axis metric]"
         "[optional: group by]",
         required=False,
     )
-    report_parser.add_argument(
+    plot_type_group.add_argument(
         "--multi-line",
         dest="multi_line",
         nargs="+",
-        action="append",
         help="generate a scaling report, requires two args: [y-axis metric] [x-axis metric]"
         "[optional: group by]",
         required=False,
     )
-    report_parser.add_argument(
-        "--pandas-where",
-        dest="where",
-        action="store",
-        help="Down select data to plot (useful for complex workspaces with collisions). Takes"
-        " pandas query format",
-        required=False,
-    )
-    report_parser.add_argument(
+    plot_type_group.add_argument(
         "--compare",
         dest="compare",
         nargs="+",
-        action="append",
         help="generate a comparison report, requires at least two args: [FOM 1] [Additional FOMs]"
         "[optional: group by(s)]",
         required=False,
     )
-    report_parser.add_argument(
+    plot_type_group.add_argument(
         "--foms",
         dest="foms",
         action="store_true",
         help="generate a FOM report, showing values of FOMs for each experiment",
         required=False,
     )
+    report_parser.add_argument(
+        "--pandas-where",
+        dest="where",
+        action="store",
+        help="Down select data to plot (useful for complex workspaces with collisions). Takes"
+        " pandas query format",
+        required=False,
+    )
     report_parser.add_argument(
         "-n",
         "--normalize",