Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard load-options that start with WINDOWS #621

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions load-options.c
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,14 @@ parse_load_options(EFI_LOADED_IMAGE *li)
}
}

/*
* Windows bcdedit.exe puts "WINDOWS\0" (in 8-bit) in the beginning of
* the options, so if we see that, we know it's not useful to us.
*/
if (li->LoadOptionsSize >= 8)
if (CompareMem(li->LoadOptions, "WINDOWS", 8) == 0)
return EFI_SUCCESS;

loader_str = split_load_options(li->LoadOptions, li->LoadOptionsSize,
&remaining, &remaining_size);

Expand Down