Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fallback to default loader when encountering errors on network boot #666

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nathan-omeara
Copy link

Only certain errors trigger fallback to the default loader name. This change allows fallback when encountering EFI_TFTP_ERROR as well. And ideally would also handle EFI_HTTP_ERROR the same way, but that requires updating gnu-efi to a version newer than the shim-15.8 branch.

This fixes the issue reported in #649 that prevents boot on some models of PC.

…boot

Only certain errors trigger fallback to the default loader name.  This change allows fallback when encountering `EFI_TFTP_ERROR` as well.  And ideally would also handle `EFI_HTTP_ERROR` the same way, but that requires updating gnu-efi to a version newer than the shim-15.8 branch.

This fixes the issue reported in rhboot#649 that prevents boot on some models of PC.

Signed-off-by: Nathan O'Meara <[email protected]>
Signed-off-by: Nathan O'Meara <[email protected]>
@nathan-omeara
Copy link
Author

@vathpela @jsetje

Could one of you take a look at this PR to address #649 ?

shim.c Outdated Show resolved Hide resolved
Remove this after shim pulls the latest gnu-efi release.

Signed-off-by: Nathan O'Meara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants