[bug] allow files excluded from vscode settings to be found #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋 !
I noticed a small weird interaction where vscode.workspace.findFiles will not work properly if the file passed in is in the user's file.excluded settings.
I.e, if we have the following folders excluded from vscode search because it slows down vscode's performance, but coverage files are also stored here.
Thus, if we try to link
**/bazel-out/_coverage/_coverage_report.dat
as the lcov file, vscode will fail to return any files unless we mark the second parameter exclude as Null