Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] allow files excluded from vscode settings to be found #15

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Ryang20718
Copy link
Contributor

Hi 👋 !

I noticed a small weird interaction where vscode.workspace.findFiles will not work properly if the file passed in is in the user's file.excluded settings.

I.e, if we have the following folders excluded from vscode search because it slows down vscode's performance, but coverage files are also stored here.

  "files.exclude": {
    "**/bazel-bin": true,
    "**/bazel-out": true,
    "**/bazel-testlogs": true,
    "**/outputs": true
  },

Thus, if we try to link **/bazel-out/_coverage/_coverage_report.dat as the lcov file, vscode will fail to return any files unless we mark the second parameter exclude as Null

image

@Ryang20718
Copy link
Contributor Author

@rherrmannr When you have a chance, wondering if you could take a look at this change please?

There shouldn't be any downsides to this since the user is specifying where the lcov files are. I usually gitignore and exclude lcov files from vscode's search to slightly improve indexing speed :)

@rherrmannr
Copy link
Owner

Hey @Ryang20718

thanks for your contribution. It makes sense that excluded folders should be checked for lcov files.

@rherrmannr rherrmannr merged commit 2ab4e74 into rherrmannr:master Jan 10, 2025
1 check passed
@Ryang20718
Copy link
Contributor Author

@rherrmannr Thanks for merging! When you have a moment, if you could cut a new release for the vscode extension store, would be much appreciated!

@rherrmannr
Copy link
Owner

Hey @Ryang20718, I have published a new version, which includes your fix. It will be 1.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants