Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding keyboard settings with localectl #561

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding keyboard settings with localectl #561

wants to merge 2 commits into from

Conversation

adamkankovsky
Copy link
Contributor

image

@adamkankovsky adamkankovsky force-pushed the keyboard-screen branch 3 times, most recently from 1f1c84b to 8b08f44 Compare December 18, 2024 11:24
KKoukiou
KKoukiou reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, please add tests.

src/components/localization/InstallationLanguage.jsx Outdated Show resolved Hide resolved
src/components/localization/InstallationLanguage.jsx Outdated Show resolved Hide resolved
src/components/localization/InstallationLanguage.jsx Outdated Show resolved Hide resolved
src/actions/localization-actions.js Outdated Show resolved Hide resolved
src/actions/localization-actions.js Outdated Show resolved Hide resolved
src/actions/localization-actions.js Outdated Show resolved Hide resolved
src/apis/localization.js Outdated Show resolved Hide resolved
src/components/localization/InstallationLanguage.jsx Outdated Show resolved Hide resolved
@adamkankovsky adamkankovsky force-pushed the keyboard-screen branch 4 times, most recently from 306f406 to 22579d8 Compare December 19, 2024 10:55
jkonecny12
jkonecny12 requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use existing code in Anaconda. In general keyboard layouts logic is hard a lot of specifics which might give us a lot of headache especially if we would keep the code on two places.

src/apis/localization.js Outdated Show resolved Hide resolved
src/apis/localization.js Outdated Show resolved Hide resolved
src/apis/localization.js Outdated Show resolved Hide resolved
@adamkankovsky adamkankovsky force-pushed the keyboard-screen branch 7 times, most recently from 70e5589 to 78bf480 Compare January 14, 2025 15:29
@adamkankovsky adamkankovsky force-pushed the keyboard-screen branch 2 times, most recently from 130f4ed to 6fb31ee Compare January 14, 2025 15:43
@adamkankovsky adamkankovsky force-pushed the keyboard-screen branch 2 times, most recently from 1059067 to bdb938f Compare January 15, 2025 13:26
@adamkankovsky
Adding keyboard setting with dbus
b402224 
# Conflicts:
#	src/components/localization/InstallationLanguage.jsx

# Conflicts:
#	src/components/localization/InstallationLanguage.jsx
#	src/components/localization/InstallationLanguage.scss
@adamkankovsky
Adding tests for keyboard selection
5000fcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKoukiou KKoukiou Awaiting requested review from KKoukiou

@jkonecny12 jkonecny12 Awaiting requested review from jkonecny12

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamkankovsky @jkonecny12 @KKoukiou