Allow reusing existing "empty" filesystems for / #5416
Conversation
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
Hello @vojtechtrefny! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-02-08 10:00:36 UTC |
vojtechtrefny
force-pushed
the
master_anaconda-root-reformat-check-change
branch
from
8d4843f to
fd81dd4
Compare
vojtechtrefny
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
vojtechtrefny
force-pushed
the
master_anaconda-root-reformat-check-change
branch
from
fd81dd4 to
e5f937f
Compare
vojtechtrefny
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
@vojtechtrefny this is blocked on merging till storaged-project/blivet#1188 gets released in rawhide I guess, can you confirm? |
The blivet PR is now merged and built in the daily copr so it should no longer block this. (But we then need to coordinate releases of blivet and anaconda in rawhide to make sure we don't break Fedora.) |
vojtechtrefny
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
We plan a new release next Tuesday. Do you plan to release this in rawhide before that? |
I actually released 3.9.0 today. |
|
/kickstart-test --testtype smoke |
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
Good point, I've added a new commit with the version bump. |
vojtechtrefny
force-pushed
the
master_anaconda-root-reformat-check-change
branch
from
f03bbae to
e2a80e6
Compare
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
1 similar comment
|
/kickstart-test --testtype smoke |
We currently require that filesystem for / must be newly formatted by Anaconda, with the new storage workflow the filesystems created in Cockpit doesn't need to be reformatted so the check needs to be adjusted to check if the filesystem selected for / is empty and force the reformatting only when it contains some preexisting data.
KKoukiou
force-pushed
the
master_anaconda-root-reformat-check-change
branch
from
e2a80e6 to
6c8876c
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
We currently require that filesystem for / must be newly formatted by Anaconda, with the new storage workflow the filesystems created in Cockpit doesn't need to be reformatted so the check needs to be adjusted to check if the filesystem selected for / is empty and force the reformatting only when it contains some preexisting data.
Depends on: storaged-project/blivet#1188