RHEL 10: Disable keyboard switching with a shortcut in boot.iso #6105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's use inheritance to show which code is used for installation and what for compositor control. It increases the readability and improve modifications for the future use. To make it correct it is split into Base class and two specific classes. That way it is crystal clear what is used for what and there should not be constant fighting between different usages and side effects. As a side effect this change will fix a potential issue when installed system which doesn't selected `options` during the installation will use options from the running system. This is harder to achieve state but it could happen. (cherry picked from commit 120fd8c) Resolves: RHEL-74504 Related: RHEL-71880
(cherry picked from commit c391efd) Resolves: RHEL-74504 Related: RHEL-71880
This is a workaround for https://issues.redhat.com/browse/RHEL-71880. We need this workaround to avoid users confusion. Without this the keyboard switching will work but it is not visible to users, so they could easily switch layouts without noticing it and wrote passwords wrong. (cherry picked from commit be32044) Resolves: RHEL-74504 Related: RHEL-71880
|
/kickstart-test --testtype smoke |
|
/kickstart-test --testtype keyboard |
jkonecny12
changed the title
jkonecny12
changed the title
jkonecny12
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keyboard switching recently migrated to localed. However, there is a bug reported that the keyboard switching with a keyboard shortcut doesn't work. However, that is not completely true, the keyboard switching correctly works but is not propagated to localed so Anaconda is not aware of the layout switch.
This behavior is much more problematic. Even reporters of the bug assumed that the keyboard switching doesn't work at all. Users could easily drop into a trap of using different keyboard layout on passwords during the installation then what they think is used.
Manual keyboard switching from Anaconda still works as expected. This is workaround which should be removed when bugs on gnome-kiosk are resolved:
NOTE:
Part of this change is code re-factorization which splits the LocaledWrapper class based on the usage (compositor / installation). This change improves readability but also fixes potential bug when xkboptions from compositor are stored to the installed system instead of the user defined ones.
Backport of #6090
Resolves: RHEL-74504