Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1277: Whitelist SELinux metrics #657

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Dec 5, 2023

Run make whitelisted_metrics && make to get new SELinux metrics into telemetry whitelist.

Approval from Metrics folks: https://issues.redhat.com/browse/STOR-1277, openshift/cluster-storage-operator#422 (review) and openshift/cluster-monitoring-operator#2155

It generated also acm_console_page_count:sum that I am not interested in, but I trust your generator scripts.

@jacobbaungard
Copy link
Member

Please re-generate resources/services/telemeter-template.yaml and check that in as well. make manifests should do it, although sometimes make incorrectly claims it's up to date, in which case deleting the file then running make manifests should do it.

Run `make whitelisted_metrics && make` to get new SELinux metrics into
telemetry whitelist.
@jsafrane jsafrane force-pushed the sync-selinux-metrics branch from 0c454bf to 1bb5ce6 Compare December 6, 2023 15:07
@jsafrane
Copy link
Contributor Author

jsafrane commented Dec 6, 2023

@jacobbaungard updated by make manifests.

Copy link
Member

@jacobbaungard jacobbaungard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jacobbaungard jacobbaungard merged commit 4149b15 into rhobs:main Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants