Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add SOP for remote write incident management #659

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

philipgough
Copy link
Contributor

* Ensure Thanos Receive is running and healthy.
* Ensure the hashring is not being OOM killed.
* If there are OOM events, check if traffic into the hashring has increased.
* If there is an unexpected increase in traffic, rate limit accordingly on observatorium-api for the tenant.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secondary point, but i think we should probably document this process as well and link it here. (not an ask for right now, just future)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

* If there are CPU throttling events, check if traffic into the hashring has increased.
* If there is an unexpected increase in traffic, rate limit accordingly on observatorium-api for the tenant.
* If there is an expected increase in traffic, adjust the CPU limits accordingly in the StatefulSet spec.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no increase in traffic, but we run into these issues we should have a documented 'check if there have been changes and roll them back' SOP (also for the future not rn)

Might be worth adding that as a thing to consider.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like that is getting into the obvious then and it comes to a point like where do you stop documenting things?

Copy link
Contributor

@moadz moadz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! added some NIT's

@philipgough philipgough marked this pull request as ready for review December 11, 2023 12:20
@philipgough philipgough merged commit b98b76f into rhobs:main Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants