Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSD-28074] Change Deployment SSS #665

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

apahim
Copy link
Collaborator

@apahim apahim commented Jan 30, 2025

The goal is to remove Subscription, CatalogSource and OperatorGroup from
all clusters but MCs, SCs and RHOAM.

@apahim apahim requested a review from a team as a code owner January 30, 2025 12:31
@apahim apahim requested review from danielmellado and PeterYurkovich and removed request for a team January 30, 2025 12:31
Copy link

openshift-ci bot commented Jan 30, 2025

Hi @apahim. Thanks for your PR.

I'm waiting for a rhobs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jan--f
Copy link
Collaborator

jan--f commented Jan 30, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot removed the lgtm label Jan 30, 2025
@apahim apahim changed the title [OSD-28074] Change SSS resourceApplyMode to Upsert Draft: [OSD-28074] Change SSS resourceApplyMode to Upsert Jan 30, 2025
@apahim apahim changed the title Draft: [OSD-28074] Change SSS resourceApplyMode to Upsert Draft: [OSD-28074] Change Deployment SSS Jan 30, 2025
The goal is to remove Subscription, CatalogSource and OperatorGroup from
all clusters but MCs, SCs and RHOAM.

Signed-off-by: Amador Pahim <[email protected]>
@apahim apahim changed the title Draft: [OSD-28074] Change Deployment SSS [OSD-28074] Change Deployment SSS Jan 30, 2025
Copy link

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apahim, jan--f, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jan--f,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier simonpasquier merged commit 5083efb into rhobs:main Jan 30, 2025
0 of 4 checks passed
@simonpasquier
Copy link
Contributor

I merged it without the CI approval as it was discussed with @apahim and @jan--f . Since it's only changing the SelectorSyncSet template, it must have no effect on the operator itself.

@jan--f
Copy link
Collaborator

jan--f commented Jan 30, 2025

Was just typing the same :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants