Cmake improvements #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgsocks
force-pushed
the
cmake-improvements
branch
2 times, most recently
from
b137aa8 to
e109ef6
Compare
This CMake project only had one executable target, so there was no way to compile it as a library. This commit splits the executable target into two library targets using the [shared static starter][1] repo by Alex Reinking for reference. [1]: https://github.com/alexreinking/SharedStaticStarter
pgsocks
force-pushed
the
cmake-improvements
branch
from
e109ef6 to
a385a20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libraries needed to be split from the executable so they can be linked to. The source checks in
WIN32is defined to include Windows headers, but mingw doesn't set that when compiling in Linux. Also, CMake has new functions for setting flags, definitions, and properties.