Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in writing_tools.py #22

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix typo in writing_tools.py #22

merged 1 commit into from
Dec 12, 2024

Conversation

p4xel
Copy link
Contributor

@p4xel p4xel commented Dec 12, 2024

rmc crashing when converting to SVG. Traceback shows error "AttributeError: type object 'Pen' has no attribute 'ERASE_AREA'"

rmc crashing when converting to SVG. Traceback shows error "AttributeError: type object 'Pen' has no attribute 'ERASE_AREA'"
@Azeirah
Copy link

Azeirah commented Dec 12, 2024

@ricklupton This can be merged immediately. It's the most common issue in all of rmc whaha

@ricklupton
Copy link
Owner

Thanks @p4xel and @Azeirah, I can merge this, but it would be good to add a test file that demonstrates the problem -- I think the ones currently in tests/rm maybe don't ever use the eraser, so this wasn't caught by the tests? If you have a very simple rm file that causes the issue (e.g. just draw a line and then use the eraser to remove part) and can add that to the test files, that would be useful too.

@ricklupton ricklupton merged commit 4dfc82c into ricklupton:main Dec 12, 2024
6 checks passed
@p4xel
Copy link
Contributor Author

p4xel commented Dec 12, 2024

@ricklupton I don't have the device to try, it is broken. I directly dumped contents of the eMMC chip and tried converting recovered files. I can email you the problematic file if you need it.

@p4xel p4xel deleted the patch-1 branch December 12, 2024 13:17
@Azeirah
Copy link

Azeirah commented Dec 12, 2024

@ricklupton I don't have the device to try, it is broken. I directly dumped contents of the eMMC chip and tried converting recovered files. I can email you the problematic file if you need it.

No need. I already made the file and added a PR

#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants