Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CrosstermEvent issue on Windows #9

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Fix for CrosstermEvent issue on Windows #9

merged 1 commit into from
Jul 6, 2024

Conversation

saintmuntzer
Copy link
Contributor

CrosstermEvent sends an event for both key press and key release on Windows, creating duplicated keyboard input. Implemented the recommended fix from Ratatui's FAQ.

CrosstermEvent sends an event for both key press and key release on Windows, creating duplicated keyboard input. Implemented the recommended fix from Ratatui's FAQ.
@ricott1 ricott1 self-requested a review July 5, 2024 06:50
@ricott1 ricott1 added the bug Something isn't working label Jul 5, 2024
@ricott1
Copy link
Owner

ricott1 commented Jul 6, 2024

Thanks for the fix!

@ricott1 ricott1 merged commit cdcd6d5 into ricott1:main Jul 6, 2024
1 check passed
@saintmuntzer saintmuntzer deleted the windows-crossterm-fix branch July 9, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants