Fix Modal Form UI #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating CHANGELOG.md in preparation for 24.0 release
Resolves @ridz1208 's anguish
Add @zaliqarosli's changes to the changelog.
Updated Step 6 of the test plan to clarify that the instruments of the test_battery entry with a NULL visit label and that falls within the candidate's age should only be displayed for a timepoint if there does not exist other test_battery entries where the visit label is set to the visit of the timepoint. See the module help text for the behaviour expected.
Resolves aces#7641
Added instrument name to the error message for clarity when it failed on conflict resolver Resolves aces#7701
) Do not autoselect first visit when creating a new timepoint. The user must manually select it, unless there is only 1 option. Resolves aces#7728
Change the keys of the multiselect to make them match the values in the cells. It use to be [scan_type_id => scan_type_label] because the scan_type_id was sent to the backend to apply the filters. Now that the filtering is done in the frontend, the options needs to be [scan_type_label => scan_type_label].
Resolves aces#7563
) Fix exception when running assign_missing_instruments in confirm mode. Resolves aces#7797
When \NDB_Factory::singleton()->settings()->getBaseURL() was called, an empty string was returned, so the emails sent to users when a survey is created were not displaying the correct URL. This bug fix should also solve similar errors from occurring in other modules that use the above line.
The issue occurs because the line $DB = $factory->database() is called in NDB_Cient before the baseURL for the factory object is set to the correct value in the BaseRouter using setBaseURL. The database() function constructs the factory's static Settings object with an empty baseURL, so the baseURL ends up being an empty string instead of the correct value. This resets the factory's settings singleton when setting the BaseURL, so that it forces a new object with the correct baseURL to be generated on the next call to settings.
Resolves aces#7668
Add ability for StaticDataTable to disable filtering. This is done when the filtering is done outside of the component and the table is only used to display data, such as in the DQT.
…tives (aces#7433) Added a new permission for a user to view and/or edit annotations for specific entries in the electrophysiology browser module. Created functions in the backend of the electrophysiology browser module to get and display derivative data from the database and to write derivative data to the database. There is no view/edit/delete functionality in the front-end added by this PR. Added the ability to download annotation files for a given session. Created a function that updates the annotation files to match changes in the database before they are downloaded by a user. This function can be called by a cronjob using the tools/update_annotation_files.php to update all the files periodically.
Fix issue where error message is not shown with an invalid email address in user accounts Resolves aces#7746
Fix glitchy scrolling of frozen column in dynamic tables.
Add missing CHANGELOG entries for 24 release.
Downloadable files i.e. minc files are missing their download links when the 'Add All' button is used to select a query. This fixes that by fixing a typo found. This also fixes a typo in the CouchDB MRI import script that fails to find any scan types to import.
… module is disabled (aces#7754) if set one module as "No" in the module_manager, user account module can't edit the user ( 500 error). The query is incorrectly including inactivated modules, which causes an exception when trying to call getLongName() on the module.
Add missing smarty template variable. Resolves aces#7792
- console error when json is null (no chunks). - add opacity on the event bars - fix a bug when pagination is set to NULL.
The publication_users_edit_perm_rel table does not have any PK and as a result, duplicate rows can be inserted. Add a PK and include a script to fix data that was incorrectly inserted. Resolves aces#7006.
…aces#7776) This fixes the escaping issue that occurs when a text field in an instrument contains an HTML special character. The solution employed here is to redirect on successful save to reload data directly from the database instead of loading it using the _POST data. This solution is sub-optimal because the escaping issue will still occur when an error is detected on instrument save and the values MUST be reloaded from the _POST array where the reload can not occur to avoid losing the unsaved data. Alternate to: aces#7777 Fixes aces#7489 Replaces aces#7490
Push v23.0.9 into main
…s#7815) Fix issue tracker to load the correct type, as required by the MultiSiteHaver interface that it declares itself to implement. phan was not able to track down the type incompatibilities because the docblock was using the less specific "array" and not the typed "\CenterID[]" array. Resolves aces#7799
…es#7698) Currently, the notification email sent by the issue tracker module has the old url . This fixes this issue by refactoring the code from an ajax directory to issue_tracker/Edit so that the BaseURL variable is available.
fix control panel position when scrolling
Removing deletion of a single entry from LorisMenuPermissions and LorisMenu since the patch before it deletes the entire table.
Since the order in which the patches were run was changed by aces#8390. The statements in this PR which add the date_format cause a truncation error since they also "remove" the log_level enum option. The patch that is run first now as patch _A already contains the date format and is thus sufficient to replace the statements removed here.
Modify the margins of the history and comments so that it's easier on the eyes to read
Reverting the code back to what it was when it was introduced as the 'keys' parameter in the query string wasn't changed back.
Fix a Fatal error on the Genomic Browser tabs: [ERROR] Can not implement UserSiteMatch on a resource type that has no sites. Fixes aces#7589
Allow users to delete their own attachment. If a user does not have Issue Tracker: Close/Edit/Re-assign/Comment on All Issues, they cannot currently delete their own attachment. Resolves aces#8006
This prevents the user from saving a Project configuration with a null Alias in a new project as well as existing projects.
…#8484) This tool tries to run pregmatch on every value pulled from the instrument Data. there is a possibility that values coming from json_decode() are decoded into floats or arrays if that is how they have been saved. if it's the case the script should just skip them and not fail
In the issue tracker module, the reporter dropdown is populated with the assignee users instead of the reporter users. This fills the reporter dropdown with the right reporter values. Fixes aces#8429
…es#7826) Currently, only users with the access_all_profiles permission can see Feedback Threads and Open Thread Summary at the profile level. Even if a user adds a feedback entry, they won't be able to see their own feedback thread unless they have the access_all_profiles permission. This change allows users to see threads and the summary that exists for candidates that they have access to (i.e., if a user is affiliated with MTL, they can now see the feedback threads & summary of MTL candidates). Fixes aces#7190
The keys in the new_profile module were lower case which forces the Sex library class to use a strtolower() function to validate the value and then submits the lowercase value in the SQL insert statement where SQL implicitly converts it to uppercase. This workflow is very risky as different versions of SQL or different databases may not recognise the lowercase and uppercase as the same word and treat it as a truncation. This is also simply bad practice and unnecessary here.
A recent change (aces#7826) to the NDB_BVL_Feedback class causes the following 500 Error to appear when the instrument_list page is loaded. This is because references are made to Timepoint::singleton instead of TimePoint::singleton. Fix casing.
…' button display (aces#8686) Currently, if the 'InstrumentResetting' config is set to 'No', the 'Delete instrument data' button is displayed and the user is able to clear the instrument. This fixes that by letting the if statement check a true boolean instead of string "true" by calling 'settingEnabled'. The PR also modifies the testing plan so this is tested in the future.
* Loris 24.1 overrides necessary to function with the Biobank Module * removing changes to package.json and webpack.config.js * update package-lock.json * adding necessery dependencies * Update package.json --------- Co-authored-by: Rida Abou-Haidar <[email protected]> Co-authored-by: Rida Abou-Haidar <[email protected]>
HenriRabalais
force-pushed
the
2023-08-24_fixModalFormUI
branch
from
e43d9dc
to
20df572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the padding on Modal Forms to give more space and prevent certain words from being cut off.