Pull 24.1 into cbig #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a fatal error thrown by the api when trying to access instrument data of a json instrument.
Fix a bug where in json instrument, CommentID is not part of the instrumentData properties.
The battery manager currently uses the Utility::getVisitList() function to list the visits available. That utility function queries the session table for existing visitlabels used in at least one session. That is problematic when you are creating a new visit and new instruments and want to assign instruments to the new visit, it simply does not show up in the drop down. This PR fixes that problem and removes the use of Utility::getInstrumentList to get an accurate list of full names for instruments and get rid of deprecation warnings Resolves aces#8459
Add PSCID uniqueness check to Candidate::createNew.
Add accessibility check for candidate metadata, not just visits.
This was made to remove overrides on COPN and CBIGR - removes notices - removes deprecation warning - add filter options to filter with limited set of options
Checkbox elements can not be defined as required like the rest of the elements. This add support for required. A required checkbox must be checked for the form to be submitted. (ie. for questions like "Have you read the terms of service?")
In the feedback panel for an instrument, the only option in 'Field Name' was 'Across all fields'. This changes how the field names for an instrument are fetched so that all of them appear as an option too.
- Fix date imported into DQT to be a real date rather than a unix timestamp. - Fix incorrect order of parameters to `join` in import script
Do not escape data being inserted in the issue tracker, it gets escaped on rendering.
Currently the numeric element type is only being added to the instrument data dictionary if it's on the top page. This fixes it so that the elements are always added to the dictionary regardless of the page.
Properly handle parsing/auto-populating of visit label when there is a suffix after the visit label in the file name. Fixes aces#8803
Some instruments use hidden fields to pass data to the frontend. This skips over the fields in the dictionary building to prevent a 500 error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating branch