Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asn1: patch ITS timestamp for 32-bit targets (see #245) #247

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

khevessy
Copy link
Contributor

@khevessy khevessy commented Feb 6, 2025

Tried to implement aforementioned fix based on https://github.com/riebl/vanetza/blob/master/vanetza/asn1/patches/security-64bit-types.patch - as advised by @riebl in #245.

Raphael, please, I am not sure what does the asn_INTEGER_specifics_t structure mean, does it also have to be added here?

@riebl
Copy link
Owner

riebl commented Feb 7, 2025

Thanks for your work, Karel! Yes, I think the the asn_INTEGER_specifics_t structure is necessary as the encoding and decoding otherwise defaults to "signed integer", see

if(specs && specs->field_unsigned) {

So from all these "specifics", the field_unsigned flag is important for us in this case.

@khevessy
Copy link
Contributor Author

khevessy commented Feb 7, 2025

Thanks for the explanation. Added the structure now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants