Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Program serialization is deterministic, and program equality checks have been corrected. #1767

Merged
merged 9 commits into from
Apr 17, 2024
Merged

fix: Program serialization is deterministic, and program equality checks have been corrected. #1767

merged 9 commits into from
Apr 17, 2024

Conversation

MarquessV
Copy link
Contributor

@MarquessV MarquessV commented Apr 16, 2024 •
edited
Loading

Description

Closes #1766

Checklist

  • The PR targets the master branch
  • The above description motivates these changes.
  • The change is atomic and can be described by a single commit (your PR will be squashed on merge).
  • All changes to code are covered via unit tests.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.

@MarquessV MarquessV linked an issue Apr 16, 2024 that may be closed by this pull request
Update qcs-sdk-python/quil to pull in CalibrationSet improvements #1765
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
7189 6334 88% 87% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
pyquil/quil.py 84% 🟢
TOTAL 84% 🟢

updated for commit: c6f317d by action🐍

@MarquessV MarquessV marked this pull request as ready for review April 16, 2024 00:34
@MarquessV MarquessV requested a review from a team as a code owner April 16, 2024 00:34
kalzoo
kalzoo previously approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@kalzoo kalzoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending CI, lgtm

edit, blocking comment: the order of calibrations does still matter.

kalzoo
kalzoo reviewed Apr 16, 2024
View reviewed changes
test/unit/test_quil.py Outdated Show resolved Hide resolved
@kalzoo kalzoo dismissed their stale review April 16, 2024 00:51

missed the point about DEFCAL equality

@MarquessV MarquessV changed the title fix: Programs with the same set of calibrations compare as equal, regardless of their order fix: Program serialization is deterministic, and program equality checks have been corrected. Apr 17, 2024
@MarquessV MarquessV merged commit 08fd1a7 into master Apr 17, 2024
22 checks passed
@MarquessV MarquessV deleted the 1765-update-qcs-sdk-pythonquil-to-pull-in-calibrationset-improvements branch April 17, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalzoo kalzoo kalzoo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Program equality is too strict Update qcs-sdk-python/quil to pull in CalibrationSet improvements
2 participants
@MarquessV @kalzoo