fix: Unpickling an AbstractInstruction will result in an AbstractInstruction instead of a quil Instruction
#1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tcion`s instead of `quil` `Instruction`s
…ruction instead of a `quil` Instruction
MarquessV
changed the title
AbstractInstruction will result in an AbstractInstruction instead of a quil Instruction
|
| Report | Tue, August 13, 2024 at 22:36:14 UTC |
| Project | pyquil |
| Branch | 1800-pickling-fix |
| Testbed | ci-runner-linux |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| test/benchmarks/test_program.py::test_copy_everything_except_instructions | ✅ (view plot) | 9,963,794,907.60 (-2.60%) | 10,465,131,779.23 (95.21%) |
| test/benchmarks/test_program.py::test_instructions | ✅ (view plot) | 3,762,912,532.80 (-3.95%) | 4,044,600,481.93 (93.04%) |
| test/benchmarks/test_program.py::test_iteration | ✅ (view plot) | 3,779,460,840.20 (-3.74%) | 4,048,144,930.53 (93.36%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
jselig-rigetti
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
LGTM, looks like it includes the changes from #1799 as well though
pyquil/quilbase.py
Outdated
| @instructions.setter | ||
| def instructions(self, instructions: list[AbstractInstruction]) -> None: | ||
| self.instrs = instructions | ||
|
|
There was a problem hiding this comment.
Does this include work from #1799 then?
7 tasks
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1800
Checklist
masterbranch