Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getter and setter methods from TransformOptions #50

Merged

Conversation

SeanPMulligan
Copy link
Contributor

This commit removes the getter and setter methods for print_ir_before_all and makes the print_ir_before_all field public. It also removes the setter method for write and makes the writer field public. Reference to issue #44

This commit removes the getter and setter methods for
print_ir_before_all and makes the print_ir_before_all field public.
It also removes the setter method for write and makes the writer field
public.
@rikhuijzer
Copy link
Owner

Hi @SeanPMulligan thank you for making this pull request. It definitely looks like it's going in the right direction. Could you also verify that the tests pass though? This is the error

error[E0599]: no method named `set_print_ir_before_all` found for struct `xrcf::TransformOptions` in the current scope
   --> arnoldc/src/main.rs:125:21
    |
125 |             options.set_print_ir_before_all(true);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^ method not found in `TransformOptions`

error[E0599]: no method named `set_writer` found for struct `xrcf::TransformOptions` in the current scope
   --> arnoldc/src/main.rs:128:21
    |
128 |             options.set_writer(out);
    |                     ^^^^^^^^^^ method not found in `TransformOptions`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `arnoldc` (bin "arnoldc" test) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.

To locally verify that everything works run

cargo test

or

cargo watch -x test

@rikhuijzer rikhuijzer merged commit 1934906 into rikhuijzer:main Feb 14, 2025
7 checks passed
@rikhuijzer
Copy link
Owner

Very nice! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants