Remove unused name (flutter#165)

* Remove unused name property * remove iml change
rimaad · Jul 29, 2019 · 51049af · 51049af
1 parent 56d9330
commit 51049af
Show file tree

Hide file tree

Showing 16 changed files with 19 additions and 44 deletions.
diff --git a/course/04_navigation/solution_04_navigation/lib/category.dart b/course/04_navigation/solution_04_navigation/lib/category.dart
@@ -61,7 +61,6 @@ class Category extends StatelessWidget {
           ),
           body: ConverterRoute(
             color: color,
-            name: name,
             units: units,
           ),
         );

diff --git a/course/04_navigation/solution_04_navigation/lib/converter_route.dart b/course/04_navigation/solution_04_navigation/lib/converter_route.dart
@@ -14,22 +14,17 @@ import 'package:solution_04_navigation/unit.dart';
 /// While it is named ConverterRoute, a more apt name would be ConverterScreen,
 /// because it is responsible for the UI at the route's destination.
 class ConverterRoute extends StatelessWidget {
-  /// This [Category]'s name.
-  final String name;
-
   /// Color for this [Category].
   final Color color;
 
   /// Units for this [Category].
   final List<Unit> units;
 
-  /// This [ConverterRoute] requires the name, color, and units to not be null.
+  /// This [ConverterRoute] requires the color and units to not be null.
   const ConverterRoute({
-    @required this.name,
     @required this.color,
     @required this.units,
-  })  : assert(name != null),
-        assert(color != null),
+  })  : assert(color != null),
         assert(units != null);
 
   @override

diff --git a/course/04_navigation/task_04_navigation/lib/converter_route.dart b/course/04_navigation/task_04_navigation/lib/converter_route.dart
@@ -17,8 +17,8 @@ class ConverterRoute extends StatelessWidget {
   /// Units for this [Category].
   final List<Unit> units;
 
-  /// This [ConverterRoute] requires the name, color, and units to not be null.
-  // TODO: Pass in the [Category]'s name and color
+  /// This [ConverterRoute] requires the color and units to not be null.
+  // TODO: Pass in the [Category]'s color
   const ConverterRoute({
     @required this.units,
   }) : assert(units != null);

diff --git a/course/04_navigation/task_04_navigation/task_04_navigation.iml b/course/04_navigation/task_04_navigation/task_04_navigation.iml
@@ -10,5 +10,6 @@
     <orderEntry type="inheritedJdk" />
     <orderEntry type="sourceFolder" forTests="false" />
     <orderEntry type="library" name="Dart SDK" level="project" />
+    <orderEntry type="library" name="Dart Packages" level="project" />
   </component>
 </module>
diff --git a/course/05_stateful_widgets/solution_05_stateful_widgets/lib/category.dart b/course/05_stateful_widgets/solution_05_stateful_widgets/lib/category.dart
@@ -61,7 +61,6 @@ class Category extends StatelessWidget {
           ),
           body: ConverterRoute(
             color: color,
-            name: name,
             units: units,
           ),
         );

diff --git a/course/05_stateful_widgets/solution_05_stateful_widgets/lib/converter_route.dart b/course/05_stateful_widgets/solution_05_stateful_widgets/lib/converter_route.dart
@@ -14,22 +14,17 @@ import 'package:solution_05_stateful_widgets/unit.dart';
 /// While it is named ConverterRoute, a more apt name would be ConverterScreen,
 /// because it is responsible for the UI at the route's destination.
 class ConverterRoute extends StatefulWidget {
-  /// This [Category]'s name.
-  final String name;
-
   /// Color for this [Category].
   final Color color;
 
   /// Units for this [Category].
   final List<Unit> units;
 
-  /// This [ConverterRoute] requires the name, color, and units to not be null.
+  /// This [ConverterRoute] requires the color and units to not be null.
   const ConverterRoute({
-    @required this.name,
     @required this.color,
     @required this.units,
-  })  : assert(name != null),
-        assert(color != null),
+  })  : assert(color != null),
         assert(units != null);
 
   @override

diff --git a/course/05_stateful_widgets/solution_05_stateful_widgets/solution_05_stateful_widgets.iml b/course/05_stateful_widgets/solution_05_stateful_widgets/solution_05_stateful_widgets.iml
@@ -10,5 +10,6 @@
     <orderEntry type="inheritedJdk" />
     <orderEntry type="sourceFolder" forTests="false" />
     <orderEntry type="library" name="Dart SDK" level="project" />
+    <orderEntry type="library" name="Dart Packages" level="project" />
   </component>
 </module>
diff --git a/course/05_stateful_widgets/task_05_stateful_widgets/lib/category.dart b/course/05_stateful_widgets/task_05_stateful_widgets/lib/category.dart
@@ -61,7 +61,6 @@ class Category extends StatelessWidget {
           ),
           body: ConverterRoute(
             color: color,
-            name: name,
             units: units,
           ),
         );

diff --git a/course/05_stateful_widgets/task_05_stateful_widgets/lib/converter_route.dart b/course/05_stateful_widgets/task_05_stateful_widgets/lib/converter_route.dart
@@ -15,22 +15,17 @@ import 'package:task_05_stateful_widgets/unit.dart';
 /// because it is responsible for the UI at the route's destination.
 // TODO: Make ConverterRoute a StatefulWidget
 class ConverterRoute extends StatelessWidget {
-  /// This [Category]'s name.
-  final String name;
-
   /// Color for this [Category].
   final Color color;
 
   /// Units for this [Category].
   final List<Unit> units;
 
-  /// This [ConverterRoute] requires the name, color, and units to not be null.
+  /// This [ConverterRoute] requires the color and units to not be null.
   const ConverterRoute({
-    @required this.name,
     @required this.color,
     @required this.units,
-  })  : assert(name != null),
-        assert(color != null),
+  })  : assert(color != null),
         assert(units != null);
 
   // TODO: Create State object for the ConverterRoute

diff --git a/course/05_stateful_widgets/task_05_stateful_widgets/task_05_stateful_widgets.iml b/course/05_stateful_widgets/task_05_stateful_widgets/task_05_stateful_widgets.iml
@@ -10,5 +10,6 @@
     <orderEntry type="inheritedJdk" />
     <orderEntry type="sourceFolder" forTests="false" />
     <orderEntry type="library" name="Dart SDK" level="project" />
+    <orderEntry type="library" name="Dart Packages" level="project" />
   </component>
 </module>
diff --git a/course/06_input/solution_06_input/lib/category.dart b/course/06_input/solution_06_input/lib/category.dart
@@ -61,7 +61,6 @@ class Category extends StatelessWidget {
           ),
           body: ConverterRoute(
             color: color,
-            name: name,
             units: units,
           ),
           // This prevents the attempt to resize the screen when the keyboard

diff --git a/course/06_input/solution_06_input/lib/converter_route.dart b/course/06_input/solution_06_input/lib/converter_route.dart
@@ -15,22 +15,17 @@ const _padding = EdgeInsets.all(16.0);
 /// While it is named ConverterRoute, a more apt name would be ConverterScreen,
 /// because it is responsible for the UI at the route's destination.
 class ConverterRoute extends StatefulWidget {
-  /// This [Category]'s name.
-  final String name;
-
   /// Color for this [Category].
   final Color color;
 
   /// Units for this [Category].
   final List<Unit> units;
 
-  /// This [ConverterRoute] requires the name, color, and units to not be null.
+  /// This [ConverterRoute] requires the color and units to not be null.
   const ConverterRoute({
-    @required this.name,
     @required this.color,
     @required this.units,
-  })  : assert(name != null),
-        assert(color != null),
+  })  : assert(color != null),
         assert(units != null);
 
   @override
@@ -164,8 +159,8 @@ class _ConverterRouteState extends State<ConverterRoute> {
       child: Theme(
         // This sets the color of the [DropdownMenuItem]
         data: Theme.of(context).copyWith(
-              canvasColor: Colors.grey[50],
-            ),
+          canvasColor: Colors.grey[50],
+        ),
         child: DropdownButtonHideUnderline(
           child: ButtonTheme(
             alignedDropdown: true,

diff --git a/course/06_input/solution_06_input/solution_06_input.iml b/course/06_input/solution_06_input/solution_06_input.iml
@@ -10,5 +10,6 @@
     <orderEntry type="inheritedJdk" />
     <orderEntry type="sourceFolder" forTests="false" />
     <orderEntry type="library" name="Dart SDK" level="project" />
+    <orderEntry type="library" name="Dart Packages" level="project" />
   </component>
 </module>
diff --git a/course/06_input/task_06_input/lib/category.dart b/course/06_input/task_06_input/lib/category.dart
@@ -61,7 +61,6 @@ class Category extends StatelessWidget {
           ),
           body: ConverterRoute(
             color: color,
-            name: name,
             units: units,
           ),
           // This prevents the attempt to resize the screen when the keyboard

diff --git a/course/06_input/task_06_input/lib/converter_route.dart b/course/06_input/task_06_input/lib/converter_route.dart
@@ -15,22 +15,17 @@ const _padding = EdgeInsets.all(16.0);
 /// While it is named ConverterRoute, a more apt name would be ConverterScreen,
 /// because it is responsible for the UI at the route's destination.
 class ConverterRoute extends StatefulWidget {
-  /// This [Category]'s name.
-  final String name;
-
   /// Color for this [Category].
   final Color color;
 
   /// Units for this [Category].
   final List<Unit> units;
 
-  /// This [ConverterRoute] requires the name, color, and units to not be null.
+  /// This [ConverterRoute] requires the color and units to not be null.
   const ConverterRoute({
-    @required this.name,
     @required this.color,
     @required this.units,
-  })  : assert(name != null),
-        assert(color != null),
+  })  : assert(color != null),
         assert(units != null);
 
   @override

diff --git a/course/06_input/task_06_input/task_06_input.iml b/course/06_input/task_06_input/task_06_input.iml
@@ -10,5 +10,6 @@
     <orderEntry type="inheritedJdk" />
     <orderEntry type="sourceFolder" forTests="false" />
     <orderEntry type="library" name="Dart SDK" level="project" />
+    <orderEntry type="library" name="Dart Packages" level="project" />
   </component>
 </module>