Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plus Code - Short Form Support #623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Logic-gate
Copy link

Before merging, note that 857W+J3 Portofino, Metropolitan City of Genoa, Italy and 857W+J3 Portofino, Italy do not match RE_PLUS_CODE_SHORT regex and raises the following errors.

[W] unknown:93 - file:///usr/share/harbour-pure-maps/qml/MapErrorPage.qml:93:27: Unable to assign [undefined] to QString
[W] unknown:116 - file:///usr/share/harbour-pure-maps/qml/MapErrorPage.qml:116:36: Unable to assign QQuickAnchorLine to double
[W] unknown:0 - "Illegal point coordinates when read as QGeoCoordinate, point 0"

I am not entirely sure why it's happening since C53X+C9X Cicagna, Metropolitan City of Genoa, Italy fails gracefully after matching the regex. I initially thought it had something to do with the 3 part reference location, but it appears that something else is happening. Might be that it's being matched or caught prior to parsing short codes.

@rinigus
Copy link
Owner

rinigus commented Aug 20, 2022

I presume you will try to rewrite or test with splitting on space(s) and then trying to recover full Plus Code. However, small feedback:

  1. parse_plus_code doesn't do anymore what it would be expected from its name
  2. methods in Pure Maps are ordered alphabetically (already from the beginning of the code and legacy of Osmo's days)

@Logic-gate
Copy link
Author

Yes, I intend to test your suggestion. I just haven't had the time; even though it's a minor fix. Will hopefully attend to it this week.

In regards to your feedback. Sure, I will follow the code's convention.

Copy link

@Hamaster2 Hamaster2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ترجمه"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants