feat: add NotNullIfNotNull attribute on generated methods, support it on user implemented methods #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latonz
force-pushed
the
1614-nullable-attributes
branch
2 times, most recently
from
e3fc534 to
33e9bfe
Compare
latonz
changed the title
latonz
force-pushed
the
1614-nullable-attributes
branch
4 times, most recently
from
43ee375 to
7bb382c
Compare
latonz
force-pushed
the
1614-nullable-attributes
branch
16 times, most recently
from
974bb17 to
738fa07
Compare
… on user implemented methods If nullable attributes are not available, the attribute is not emitted and
latonz
force-pushed
the
1614-nullable-attributes
branch
from
738fa07 to
3b217fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1709
Related #1614