Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support named mappings for existing target objects #1720

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

clegoz
Copy link
Contributor

@clegoz clegoz commented Feb 15, 2025

feat: support named mappings for existing target objects

Description

Fixes #1649
Fixes #1700

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

@latonz
Copy link
Contributor

latonz commented Feb 16, 2025

Thanks for your contribution. Could you please explain the reason behind your choice of a different approach for implementing this compared to the new instance mappings (using UseNamedMappingBuilder.TryBuildMapping)? I'm concerned that your implementation doesn't seem to address diagnostics like RMG072 and RMG073. Could you please add tests to verify this and maybe adjust your implementation to match the existing approach (see UseNamedMappingBuilder.TryBuildMapping)?

@latonz latonz added the enhancement New feature or request label Feb 17, 2025
@clegoz clegoz force-pushed the feature/named_existing_target_mapping branch from 76e329e to 44c277f Compare February 20, 2025 23:18
@clegoz
Copy link
Contributor Author

clegoz commented Feb 20, 2025

I made changes accordingly to warn when types do not match, and also added CompositeMemberExistingTargetMapping (not sure about the name) to map source and target types to the referenced mapping types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants