fix amendments backtracking #298
Conversation
| @@ -39,7 +39,7 @@ const AMENDMENT_VERSION_REGEX = | |||
| /\| \[(?<amendmentName>[a-zA-Z0-9_]+)\][^\n]+\| (?<version>v[0-9]*\.[0-9]*\.[0-9]*|TBD) *\|/u | |||
|
|
|||
| export const NETWORKS_HOSTS = new Map([ | |||
| ['main', 'ws://s2.ripple.com:51233'], | |||
| ['main', 'wss://xrplcluster.com'], | |||
There was a problem hiding this comment.
We often got rate limit while looping and sending ledger and tx RPC to clio (not sure if it's because of the recent issue) to backtrack amendments. We can either change this to xrpl-cluster completely or use it as a backup.
There was a problem hiding this comment.
Has this been discussed with the Clio folks?
There was a problem hiding this comment.
RippledError(You are placing too much load on the server., {\"error\":\"slowDown\",\"error_code\":10,\"error_message\":\"You are placing too much load on the server.\",\"status\":\"error This happens once in a while with Clio
There was a problem hiding this comment.
Just posted my question on their channel
| @@ -264,11 +264,15 @@ async function backtrackNetworkAmendmentStatus( | |||
| index < currentLedger; | |||
| index += 256 | |||
| ) { | |||
| // Use api V1 instead of the default (V2) since we don't have the correct | |||
| // LedgerResponseExpanded type for V2 | |||
| // TODO: change to V2 once the issue is fixed. | |||
There was a problem hiding this comment.
I recommend linking to the xrpl.js issue
High Level Overview of Change
There are 2 issues with amendment backtracking and status retrieval:
ledgerrpc for API v2 withtransactionsandexpandenabled does not matchLedgerResponseExpandedfield on xrpl.js. Use v1 for now.Type of Change