Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arch-tests for Smcsrind and Sscsrind - Draft #380

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

dansmathers
Copy link
Contributor

@dansmathers dansmathers commented Aug 30, 2023

Description

Add arch-tests for Smcsrind and Sscsrind fast-track extension
Note that these two indirect CSR extensions define a means to access
an array of registers via CSRs which will be defined by other extensions.
Until those other extensions are defined, the data read back is undefined.
So these arch tests primarily test the existence of the Smcsrind/Sscsrind
CSRs and access exceptions.

Related Issues

SAIL does not currently support Smcsrind, Sscsrind, Smstateen, Hypervisor mode.
Smcsrind/Sscsrind supported in spike: riscv-software-src/riscv-isa-sim@60c08b1
Sscsrind interaction with Smstateen still needs to be added to spike.

Ratified/Unratified Extensions

[x] Ratified
[ ] Unratified

List Extensions

These extensions are described in the PDF spec available at:
https://github.com/riscv/riscv-smcntrpmf/releases/download/v1.0_rc4-frozen/riscv-smcntrpmf-v1.0_rc4.pdf

Reference Model Used

  • SAIL
  • Spike
  • Other - < SPECIFY HERE >

Mandatory Checklist:

  • All tests are compliant with the test-format spec present in this repo ?

  • Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?

  • Ran the new tests on RISCOF in [coverage mode](https://riscof.readthedocs.io/en/stable/commands.html#coverage
    I will need help running coverage and other riscof infrastructure using spike only. SAIL is probably a long time from being able to support smstateen/hypervisor which is required by Sscsrind extension. I also had problems getting a log from spike and making sure spike Smcsrind extension is enabled by the tests.

  • Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >

  • Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >

  • Changelog entry created with a minor patch

Optional Checklist:

  • RISCV-V CTG PR link if tests were generated using it : < SPECIFY HERE >
  • Were the tests hand-written/modified ?
  • Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description
  • If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

@jamesbeyond jamesbeyond changed the base branch from main to dev May 28, 2024 16:58
@UmerShahidengr
Copy link
Collaborator

Rebased this one, removed the Changelog file. Copying the Changelog file data in this comment for future use (will be used when it will be released in main)
<<<<<<< smcsrind

[3.8.0] - 2023-08-30

  • Added Smcsrind tests
  • Added Sscsrind tests
  • Updated encoding.h from spike for S*csrind CSRs
    =======

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants